From 3c650138b9b998fd1dd1645a82cf1a10c0111aff Mon Sep 17 00:00:00 2001 From: Josepablo C Date: Mon, 1 Apr 2024 21:49:43 -0600 Subject: [PATCH] fix: Do not join field list of the field doesn't exists --- src/apps/private/companies/services.js | 8 +++++--- src/apps/public/public-companies/services.js | 4 +++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/apps/private/companies/services.js b/src/apps/private/companies/services.js index 96a907a..4aea62d 100644 --- a/src/apps/private/companies/services.js +++ b/src/apps/private/companies/services.js @@ -22,7 +22,9 @@ function join_field_list( obj_with_fields , list_of_fields ) for(let field_idx=0; field_idx < list_of_fields.length; field_idx++){ const field_name = list_of_fields[ field_idx ]; const new_field_name = "_" + list_of_fields[ field_idx ]; - obj_with_fields[ new_field_name ] = obj_with_fields[field_name].join(", "); + if( obj_with_fields[ field_name ] ){ + obj_with_fields[ new_field_name ] = obj_with_fields[field_name].join(", "); + } } return obj_with_fields; } @@ -195,7 +197,7 @@ const getUserLists = async(req, res) => { data_list[i].name = name; data_list[i] = join_field_list( data_list[i] , ["categories","user_city","user_state","truck_type"] ); - let categories = data_list[i].categories.map( ( c ) => c.name); + // let categories = data_list[i].categories.map( ( c ) => c.name); /** Remove not requried fields */ delete data_list[i].categories; @@ -212,7 +214,7 @@ const getUserLists = async(req, res) => { return res.status(200).send( retVal ); } catch ( err ){ console.error( err ); - return res.status(500).send({ error : "Public-Companies: Internal error" }); + return res.status(500).send({ error : "Companies: Internal error" }); } }; diff --git a/src/apps/public/public-companies/services.js b/src/apps/public/public-companies/services.js index a9d5455..c424ef6 100644 --- a/src/apps/public/public-companies/services.js +++ b/src/apps/public/public-companies/services.js @@ -21,7 +21,9 @@ function join_field_list( obj_with_fields , list_of_fields ) for(let field_idx=0; field_idx < list_of_fields.length; field_idx++){ const field_name = list_of_fields[ field_idx ]; const new_field_name = "_" + list_of_fields[ field_idx ]; - obj_with_fields[ new_field_name ] = obj_with_fields[field_name].join(", "); + if( obj_with_fields[ field_name ] ){ + obj_with_fields[ new_field_name ] = obj_with_fields[field_name].join(", "); + } } return obj_with_fields; }